Update nREPL and REPL-y #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nREPL doesn't have a hard Clojure dependency these days.
thenonameguy
reviewed
Feb 6, 2019
| @@ -8,7 +8,7 @@ | |||
| [boot.from.io.aviso.exception :refer [*fonts*]])) | |||
|
|
|||
| (def ^:dynamic *default-dependencies* | |||
| (atom '[[nrepl/nrepl "0.4.4" :exclusions [[org.clojure/clojure]]]])) | |||
| (atom '[[nrepl/nrepl "0.5.3"]])) | |||
There was a problem hiding this comment.
Suggested change
| (atom '[[nrepl/nrepl "0.5.3"]])) | |
| (atom '[[nrepl/nrepl "0.6.0"]])) |
thenonameguy
reviewed
Feb 6, 2019
| #### Improved | ||
|
|
||
| - Updated REPL-y to 0.4.3. | ||
| - Updated nREPL to 0.5.3. |
There was a problem hiding this comment.
Suggested change
| - Updated nREPL to 0.5.3. | |
| - Updated nREPL to 0.6.0. |
|
@flyboarder Can you merge this and bump the version to 0.6.0? Tools like CIDER now target nREPL 0.6 and it’d be nice if Boot users didn’t have to manually override their nREPL dependency. |
|
Yes, I’ll look into a new patch version soon. |
|
Thanks! Generally nREPL upgrades are safe, as we’re very careful about backwards compatibility. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A straightforward change.
One thing to note - nREPL introduced a config file, that ideally boot should support at some point. See https://nrepl.org/nrepl/usage/server.html#_server_options
It's not a big deal and should be trivial to do. Perhaps someone like @alexander-yakushev would like to land a hand with this, as I'm not really a boot user.