Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Makefile for boot/base having switched from maven to lein #754

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

RadicalZephyr
Copy link
Contributor

@RadicalZephyr RadicalZephyr commented Oct 27, 2019

Fixes the problems with the Makefile targets clean and install.

Description

Currently the makefile has not been updated to reflect the fact that boot/base has been migrated to be built using lein rather than maven. As a result it errors when invoked with either of these tasks. This PR fixes that by replacing the mvn invocations with equivalent leininvocations.

How Has This Been Tested?

I ran make clean and make install and saw that they both completed successfully.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@burn2delete burn2delete merged commit 5b3ea9f into boot-clj:3.0.0-SNAPSHOT Apr 22, 2021
@RadicalZephyr RadicalZephyr deleted the fix-makefile branch April 23, 2021 04:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants