Move kernel cmdline parsing to dedicated crate #1554
Merged
+43
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a new dedicated crate for kernel command line parsing functionality, moving it out of bootc-lib for better separation of concerns and modularity. Changes: - Create new bootc-kernel-cmdline crate under crates/kernel_cmdline/ - Move kernel_cmdline.rs from bootc-lib to the new crate as lib.rs - Add bootc-kernel-cmdline dependency to bootc-lib - Update imports in bootc-lib to use bootc_kernel_cmdline:: namespace - Add missing Debug derive and documentation to fix lints 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: John Eckersberg <jeckersb@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the kernel command line parsing logic into a new dedicated crate, bootc-kernel-cmdline, which improves modularity and separation of concerns. The changes are well-executed, with visibility and imports updated correctly. I've found one issue regarding inconsistent equality comparison for ParameterStr, which should be addressed to ensure predictable behavior.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new dedicated crate for kernel command line parsing functionality,
moving it out of bootc-lib for better separation of concerns and modularity.
Changes:
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Signed-off-by: John Eckersberg jeckersb@redhat.com