Skip to content

Bootstrap 4 - active class set on wrong element #12

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
pabse opened this issue Sep 18, 2017 · 2 comments
Closed

Bootstrap 4 - active class set on wrong element #12

pabse opened this issue Sep 18, 2017 · 2 comments

Comments

@pabse
Copy link
Contributor

pabse commented Sep 18, 2017

In the latest Bootstrap 4 version (v4-beta) the active class for the nav_item should not be set to the li tag. Instead it should be on the a tag having the class nav-link. See https://getbootstrap.com/docs/4.0/components/navs/#pills-with-dropdowns

This is the relevant part of the code.

@manuelmeurer
Copy link
Member

Hi, thanks for reporting this!
I don't have time to work on this right now, but would be happy for a PR! 😄

To be honest, I think there are quite a lot of issues like this with the code for Bootstrap 4.
Or does it mostly work OK for you?

@pabse
Copy link
Contributor Author

pabse commented Sep 26, 2017

I'll try to open a PR for this in the next few days.

We have no other problems with it in our application. But I will check the code for possible issues 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants