Skip to content

Add bootstrap 4 support #13

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Conversation

pabse
Copy link
Contributor

@pabse pabse commented Oct 17, 2017

This adds bootstrap 4 support with proper class assignment and all possible configurations.
(Currently Bootstrap 4.0.0-beta)

TODO for the future: Fix specs
Also TODO: Add WIKI

Basic Usage (in haml):

= navbar expand_at: :sm, brand: image_tag('test.svg'), brand_url: root_path do
   = navbar_collapse id: 'navigation', class: 'justify-content-end' do
      = navbar_group do
        = navbar_item 'Dashboard', dashboard_path

Dropdowns should also work.

Fixes #12

@manuelmeurer
Copy link
Member

💥 Fantastic, thank you! 😺

@manuelmeurer manuelmeurer reopened this Oct 18, 2017
@manuelmeurer manuelmeurer merged commit e21d0f9 into bootstrap-ruby:master Oct 18, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants