Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow overriding the wrapper class #618

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Allow overriding the wrapper class #618

merged 2 commits into from
Jan 9, 2022

Conversation

donv
Copy link
Collaborator

@donv donv commented Dec 28, 2021

The wrapper now has a mb-3 class by default which is correct by the Bootstrap 5 migration guide and documentation. 👍

However, when you want to remove the bottom margin like some of the tests do, there should be a way to omit the mb-3 class. I think wrapper_class: false should do this, so I'll add it to this PR.

Then, when you add classes, you should be able to add them to a clean slate. That means that you need to include the mb-3 class if you want it.

What do you think?

@donv donv requested a review from thimo December 28, 2021 13:19
@donv donv self-assigned this Dec 28, 2021
@donv donv force-pushed the override_wrapper_class branch from 73ff7a5 to 06c3579 Compare December 28, 2021 13:45
Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. I agree that we should have some way of overriding the default behaviour. Take a look at my comment and let me know what you think.

@donv donv merged commit 17f6522 into main Jan 9, 2022
@donv donv deleted the override_wrapper_class branch January 9, 2022 20:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants