#51 update kafka base image to bitnami #53
Conversation
| @@ -32,7 +32,6 @@ | |||
| <version.python>3.11.4</version.python> | |||
| <version.help.plugin>3.2.0</version.help.plugin> | |||
| <version.krausening>19</version.krausening> | |||
| <version.license.plugin>2.4.0</version.license.plugin> | |||
There was a problem hiding this comment.
I: moved to aissemble-parent
| <plugin> | ||
| <groupId>com.google.code.maven-replacer-plugin</groupId> | ||
| <artifactId>replacer</artifactId> | ||
| <version>1.5.3</version> |
There was a problem hiding this comment.
I: Moved configuration up to the extensions-helm POM so we just have to include the plugin to do the version replacement.
| @@ -15,6 +15,10 @@ | |||
|
|
|||
| <build> | |||
| <plugins> | |||
| <plugin> | |||
There was a problem hiding this comment.
I: Now that we are using our own image again, we need to replace the image tag with the correct version at build time so releasing is smoother.
| @@ -98,7 +98,6 @@ | |||
| <dependency> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-dependency-plugin</artifactId> | |||
| <version>${version.maven.dependency.plugin}</version> | |||
There was a problem hiding this comment.
I: Moved to dependencyManagement of aissemble-parent, but I wasn't convinced that was the right move. Happy to either move it to build-parent or just add back these version tags.
There was a problem hiding this comment.
I think its fine for now. If a different version is needed in the future then we can override it then
pom.xml
Outdated
| @@ -6,7 +6,7 @@ | |||
| <parent> | |||
| <groupId>com.boozallen.aissemble</groupId> | |||
| <artifactId>aissemble-parent</artifactId> | |||
| <version>2</version> | |||
| <version>3-SNAPSHOT</version> | |||
There was a problem hiding this comment.
I: Can be updated when aissemble-parent is released. (See related PR boozallen/aissemble-parent#3)
Updates the base image for the aissemble-kafka image from wurstmeister kafka to bitnami/kafka:3.5. The bitnami image was selected because our helm chart, aissemble-kafka-chart, is based on the bitnami kafka chart. The version 3.5 was chosen over the newer 3.7 version image because there was a major refactor to bitnami's chart in chart version 24.0 that would have required a significant refactor and testing to our chart to upgrade beyond. Instead I updated to the last compatible version of the chart, 23.0.7, which was based on the 3.5 image.
ewilkins-csi
force-pushed
the
51-replace-kafka-image
branch
from
f0ce31c to
dd0a7ad
Compare
Updates the base image for the aissemble-kafka image from wurstmeister kafka to bitnami/kafka:3.5. The bitnami image was selected because our helm chart, aissemble-kafka-chart, is based on the bitnami kafka chart. The version 3.5 was chosen over the newer 3.7 version image because there was a major refactor to bitnami's chart in chart version 24.0 that would have required a significant refactor and testing to our chart to upgrade beyond. Instead I updated to the last compatible version of the chart, 23.0.7, which was based on the 3.5 image.