Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix documentation on ProjectionFactorPPPC #1004

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Fix documentation on ProjectionFactorPPPC #1004

merged 3 commits into from
Jan 3, 2022

Conversation

dwisth
Copy link
Contributor

@dwisth dwisth commented Jan 3, 2022

A couple of small changes to ProjectionFactorPPPC:

  • Remove excess constructor, use default arguments instead
  • Fix construction documentation
  • Make some variables const where possible

@dwisth dwisth requested a review from varunagrawal January 3, 2022 05:45
varunagrawal
varunagrawal approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit 6bfad39 into develop Jan 3, 2022
@varunagrawal varunagrawal deleted the fix/projection-factor-pppc-documentation branch January 3, 2022 14:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwisth @varunagrawal