Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wrapped more things #1077

Merged
merged 8 commits into from
Feb 1, 2022
Merged

Wrapped more things #1077

merged 8 commits into from
Feb 1, 2022

Conversation

dellaert
Copy link
Member

I wrapped a number of methods that were needed when writing about SLAM. Cleaned up a few tiny bits here and there as I was wrapping. Includes:

  • loading
  • elimination
  • printing and inspecting Bayes tree/ Bayes net

@dellaert dellaert added the quick-review Quick and easy PR to review label Jan 31, 2022
@dellaert
Copy link
Member Author

@varunagrawal I know CI is broken and already fixed, but will await your review to also push any other comments you have so I don't trash CI again...

@dellaert dellaert requested a review from varunagrawal January 31, 2022 21:12
varunagrawal
varunagrawal approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sans one comment

@dellaert dellaert merged commit ee4c75f into develop Feb 1, 2022
@dellaert dellaert deleted the feature/more_wrapping branch February 1, 2022 04:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @varunagrawal