New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add shared_ptr definition for remainder of camera objects #1088

Merged

dellaert merged 1 commit into develop from fix/add-shared-ptr-for-camera-calibration-classes

Feb 5, 2022

Contributor

dwisth commented Feb 5, 2022

This is a minor usability fix.

Some of the camera calibration objects returned the expected shared_ptr e.g.

Cal3_S2Stereo::shared_ptr returns boost::shared_ptr<Cal3_S2Stereo>
Cal3Fisheye::shared_ptr returns boost::shared_ptr<Cal3Fisheye>

but others returned a different type which could be confusing, e.g.

Cal3DS2::shared_ptr returns boost::shared_ptr<Cal3>.

This PR adds some using statements to make this more consistent.


          Add shared_ptr definition for remainder of camera objects

d449113

dwisth requested a review from varunagrawal

February 5, 2022 10:28

dellaert approved these changes

View reviewed changes

Member

dellaert commented Feb 5, 2022

Thanks, clear improvement, will merge!

dellaert merged commit efe922b into develop

dellaert deleted the fix/add-shared-ptr-for-camera-calibration-classes branch

February 5, 2022 16:10

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet