Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include guards #1116

Merged
merged 5 commits into from
Feb 22, 2022
Merged

Include guards #1116

merged 5 commits into from
Feb 22, 2022

Conversation

acxz
Copy link
Contributor

@acxz acxz commented Feb 21, 2022

This PR adds missing include guards via #pragma once to various headers which are missing them.

@acxz
Copy link
Contributor Author

acxz commented Feb 21, 2022

The header files under python/ and wrap/ still have missing guards. I wasn't sure whether to add them or not. Let me know if we should and I'll add them rq.

One more file gtsam/base/debug.h has also not been baptized. This is because the multiple include is required for switching #defines in the test case check_base_program.

@varunagrawal
Copy link
Collaborator

python headers don't have guards since they serve a difference purpose. Though I guess adding guards would help, we would have to ensure the wrapping process doesn't break.

If you want to include guards in wrap, then do so here.

@varunagrawal varunagrawal merged commit 199dec5 into borglab:develop Feb 22, 2022
@acxz acxz deleted the include-guards branch February 22, 2022 23:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants