Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Correction to docs and lambdas #1390

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Correction to docs and lambdas #1390

merged 2 commits into from
Jan 18, 2023

Conversation

varunagrawal
Copy link
Collaborator

  • Updated the docstrings to properly reflect what's happening.
  • Updated some lambda names since we're computing (log-)probabilities and not errors.
  • Add a TODO about reorder_relinearize. It doesn't take pruning into account so relinearization in HybridNonlinearISAM is very slow.

@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Jan 17, 2023
@varunagrawal varunagrawal requested a review from dellaert January 17, 2023 20:59
@varunagrawal varunagrawal self-assigned this Jan 17, 2023
@dellaert
Copy link
Member

Great. I thought you were going to patch that branch I shared with you? It has the fix to the test.

@varunagrawal
Copy link
Collaborator Author

Great. I thought you were going to patch that branch I shared with you? It has the fix to the test.

I'll do that today.

@varunagrawal varunagrawal merged commit 3460147 into develop Jan 18, 2023
@varunagrawal varunagrawal deleted the hybrid/simplify-2 branch January 18, 2023 17:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert