Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Factor graph update #40

Merged
merged 3 commits into from
Jun 2, 2019
Merged

Factor graph update #40

merged 3 commits into from
Jun 2, 2019

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jun 1, 2019

Re-factored std::enable_if use, and added a method add_factors that will be used to refactor iSAM2.

Some of the push_back methods are complex, even using my new templates. If someone wants to take a look whether some of these can be simplified using C++11 please do :-) It will be in another PR.

@dellaert dellaert requested a review from chrisbeall June 1, 2019 21:33
@dellaert dellaert self-assigned this Jun 1, 2019
@dellaert
Copy link
Member Author

dellaert commented Jun 2, 2019

Checks only fail because of time limit, will merge.

@dellaert dellaert merged commit 51fb1b6 into develop Jun 2, 2019
@ghost ghost mentioned this pull request Jun 2, 2019
@dellaert dellaert deleted the feature/factor_graph_update branch June 5, 2019 14:43
varunagrawal added a commit that referenced this pull request Mar 14, 2021
aae9b4605 Merge pull request #40 from borglab/fix/instantiation-capital
dc8c67843 fix template instantiation capitalization

git-subtree-dir: wrap
git-subtree-split: aae9b4605b1a95fd0165f8ec3fede1fb7ffcb9c1
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant