Feature/stage travis #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Adding stages is the best way to avoid timeouts. If it's needed, another intermediary stage could be created: 1) gtsam 2) gtsam_unstable 3) examples / tests. |
jlblancoc
approved these changes
Jun 7, 2019
| - CCACHE_SLOPPINESS=pch_defines,time_macros | ||
| matrix: | ||
| - GTSAM_ALLOW_DEPRECATED_SINCE_V4=OFF GTSAM_BUILD_TESTS=OFF GTSAM_BUILD_UNSTABLE=ON GTSAM_BUILD_EXAMPLES_ALWAYS=ON | ||
| - GTSAM_ALLOW_DEPRECATED_SINCE_V4=OFF GTSAM_BUILD_TESTS=ON GTSAM_BUILD_UNSTABLE=ON GTSAM_BUILD_EXAMPLES_ALWAYS=OFF |
There was a problem hiding this comment.
I think that this "matrix" block could (and should?) be removed.
At least, it could be removed to check whether the list of generated jobs changes; if not, it would be clear it has no effects.
There was a problem hiding this comment.
No, I think it works as expected: it generates the eight builds: 2 platforms, 2 compilers, 2 environment settings
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a compile stage before the matrix of features is built, to populate the ccache. Works well for Linux, does still not seem to work for OSX. Somehow, even though the cache is written by the compile stage, the filenames do not match when the test stage tries to read.
I will cancel the branch build for now, let's see how the CI fares on this PR. But if it still does not work, I have no idea how to fix.