Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New readBal function #506

Merged
merged 2 commits into from
Sep 6, 2020
Merged

New readBal function #506

merged 2 commits into from
Sep 6, 2020

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Sep 3, 2020

This PR adds a new function readBal which returns the SfmData object, allowing for single line calling.

This function is particularly useful with the wrapper.

E.g.

SfmData data = readBal("example.bal")

rather than

SfmData data;
readBAL("example.bal", data);

Note I followed Google style when naming the function.

@varunagrawal varunagrawal added the feature New proposed feature label Sep 3, 2020
@varunagrawal varunagrawal self-assigned this Sep 3, 2020
@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Sep 4, 2020
@varunagrawal
Copy link
Collaborator Author

@dellaert @ProfFan this is a quick one. :)

@varunagrawal varunagrawal mentioned this pull request Sep 6, 2020
@varunagrawal varunagrawal merged commit 0c19e80 into develop Sep 6, 2020
@varunagrawal varunagrawal deleted the feature/bal-utils branch September 6, 2020 18:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New proposed feature quick-review Quick and easy PR to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants