Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CMake scripts compatible with gtsam as git submodule #674

Merged
merged 1 commit into from
Jan 17, 2021
Merged

CMake scripts compatible with gtsam as git submodule #674

merged 1 commit into from
Jan 17, 2021

Conversation

jlblancoc
Copy link
Member

Minor changes to make cmake scripts not to assume CMAKE_SOURCE_DIR is identical to GTSAM_SOURCE_DIR (and the same for *_BINARY_DIR).

PS: The GTSAM_ prefix comes from the project(GTSAM) in the root CMakeLists.txt.

dellaert
dellaert approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting you on this...

@jlblancoc jlblancoc merged commit edcd75f into develop Jan 17, 2021
@jlblancoc
Copy link
Member Author

Thanks!
It was already tested locally, and tests passed so... let's merge it 👍

@jlblancoc jlblancoc deleted the cmake-dont-assume-root-dir branch January 17, 2021 23:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlblancoc @dellaert