Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid potential wrong memory access #758

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

jlblancoc
Copy link
Member

(Spotted while randomly browsing the code)

If the user uses an invalid index, the [] operator won't check it and the program will access invalid memory. Using at() would throw instead.

If the user uses an invalid index, the [] operator won't check it and the program will access invalid memory. Using at() would throw instead.
@jlblancoc jlblancoc requested a review from dellaert April 28, 2021 10:03
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio

@dellaert dellaert merged commit 6097b8f into develop Apr 28, 2021
@varunagrawal varunagrawal deleted the fix-potential-crash branch January 28, 2023 21:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants