Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added destructor for CameraSet to remove warning #779

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

varunagrawal
Copy link
Collaborator

Just the title.

@varunagrawal varunagrawal added the easy-fix Quick and easy to fix label May 31, 2021
@varunagrawal varunagrawal requested review from ProfFan and dellaert May 31, 2021 16:43
@varunagrawal varunagrawal self-assigned this May 31, 2021
@varunagrawal varunagrawal changed the title Ddded destructor for CameraSet to remove warning Added destructor for CameraSet to remove warning May 31, 2021
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think maybe we need to rethink whether to keep inheriting std containers...

@varunagrawal
Copy link
Collaborator Author

Yeah true. This is a legacy of some previous fixes I made where the destructors needed to be explicitly added to remove warnings. Hopefully this is the last of them.

@varunagrawal varunagrawal merged commit 1c39a06 into develop Jun 2, 2021
@varunagrawal varunagrawal deleted the fix/leftover branch June 2, 2021 16:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
easy-fix Quick and easy to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants