Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix bug in LinearContainerFactor and warnings about Point3 #785

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Fix bug in LinearContainerFactor and warnings about Point3 #785

merged 2 commits into from
Jun 8, 2021

Conversation

varunagrawal
Copy link
Collaborator

Just the title.

@varunagrawal varunagrawal added bugfix Fixes an issue or bug quick-review Quick and easy PR to review easy-fix Quick and easy to fix labels Jun 6, 2021
@varunagrawal varunagrawal requested review from ProfFan and dellaert June 6, 2021 00:09
@varunagrawal varunagrawal self-assigned this Jun 6, 2021
ProfFan
ProfFan approved these changes Jun 6, 2021
View reviewed changes
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need a test case that captures this bug.

@varunagrawal
Copy link
Collaborator Author

Thanks for the reminder @ProfFan. I added a simple test case which exposes the bug. Will merge once CI passes.

@varunagrawal varunagrawal merged commit 4270399 into develop Jun 8, 2021
@varunagrawal varunagrawal deleted the fix/linear-container-factor branch June 8, 2021 00:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug easy-fix Quick and easy to fix quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @ProfFan