Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add tests for Lie::interpolate jacobians #910

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Add tests for Lie::interpolate jacobians #910

merged 1 commit into from
Oct 26, 2021

Conversation

varunagrawal
Copy link
Collaborator

Fixed #864

@varunagrawal varunagrawal added the bugfix Fixes an issue or bug label Oct 25, 2021
@varunagrawal varunagrawal requested a review from ProfFan October 25, 2021 21:16
@varunagrawal varunagrawal self-assigned this Oct 25, 2021
ProfFan
ProfFan approved these changes Oct 25, 2021
View reviewed changes
tests/testLie.cpp
@@ -129,6 +129,46 @@ TEST( testProduct, Logmap ) {
EXPECT(assert_equal(numericH, actH, tol));
}

/* ************************************************************************* */
Product interpolate_proxy(const Product& x, const Product& y, double t) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to follow the convention of the other methods. Not required per se but avoids the need to add the template parameter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@varunagrawal varunagrawal merged commit 4fc9e83 into develop Oct 26, 2021
@varunagrawal varunagrawal deleted the feature/lie-interpolate-tests branch October 26, 2021 04:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test for Lie::interpolate
2 participants
@varunagrawal @ProfFan