wkl3nk/add-ellipsis-to-rerun-button #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More than just one SBOM is offered for download. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Use title-case for these button captions. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
In case of system theme / dark in use, the CycloneDX icon variant was incorrectly chosen as the dark variant. Solve this by extending the theme state with selectedTheme and activeTheme, and when system theme is used, the active theme is decided using a media query. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Create a slicker look by not using a title. All information is included elsewhere (breadcrumb bar, menu item) anyway. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
The new module is going to host the implementations of maintenance tasks that should be scheduled periodically. Initially, add a basic interface for such tasks. Signed-off-by: Oliver Heger <oliver.heger@bosch.io>
Add a `main` function to the `tasks` module that will serve as entry point to the container image. The function determines the task(s) to execute via a configuration setting and takes care about the execution. It obtains tasks and their dependencies from a Koin configuration. Signed-off-by: Oliver Heger <oliver.heger@bosch.io>
Add a configuration for the jib plugin to create a container image with all maintenance tasks. In order to run specific tasks, this image must be launched with a corresponding configuration. Signed-off-by: Oliver Heger <oliver.heger@bosch.io>
Add the config parameter and the corresponding UI to select the package managers that should be run preceding this. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
The `listRunsBefore` function is currently used to determine ORT runs that can be deleted according to the data retention policy. For this use case, the implementation is problematic because it constructs complete `OrtRun` objects with all dependencies; this is not feasible for a larger number of results. Therefore, replace the function by a new `findRunsBefore` function that returns only the IDs of matched runs. Use a different naming scheme here, as other `list` functions typically return entities. Adapt `OrtRunsService` (which is the only client) accordingly. Signed-off-by: Oliver Heger <oliver.heger@bosch.io>
Explicitly log the numbers of successful and failed delete operations to have a better overview if something went wrong. Signed-off-by: Oliver Heger <oliver.heger@bosch.io>
Add `@easyops-cn/docusaurus-search-local` [1] as a local search plugin for Docusaurus. Fixes eclipse-apoapsis#1673. [1]: https://github.com/easyops-cn/docusaurus-search-local Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
This fixes the check for PRs from forks. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
The note sounded a bit as if there were immediate plans to be able to run without the analyzer, but this is not the case. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
This should fix another permission issue [1] when creating a PR from a fork, see the docs at [2]. [1]: https://github.com/eclipse-apoapsis/ort-server/actions/runs/12989497197/job/36222632642#step:7:22 [2]: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
The `value` property was not mapped when converting an API object to a model object. Fixes eclipse-apoapsis#1894. Signed-off-by: Oliver Heger <oliver.heger@bosch.io>
Before a scan starts in a Scanner pod, generate a `.gitconfig` environment file containing URL `insteadOf` sections. These are required if the repository contains submodules specified using SSH URLs. The `insteadOf` sections can either be generated using default values in `application.conf` or customized via the environment variable `GIT_CONFIG_URL_INSTEAD_OF`. This allows flexibility in defining what URL `insteadOf` sections are created in `.gitconfig`. Signed-off-by: Wolfgang Klenk <wolfgang.klenk2@bosch.com>
Add needed support (form validation schema and default handling) for environment variables to ORT run creation utils, in preparation of adding the support to the UI. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Use a similar component for adding the names and values for environment variables to the Analyzer configuration section as is already used for the run parameters. At this stage, secrets are not handled as part of environment variable settings. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
`mustRunAfter` part was missing from the package manager options in the "Analyzer" section of the "Job Configurations" page. Also clean the component a bit by removing all unnecessary optional chaining operators from it. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
In case environment variables have been set for the Analyzer in the run, list them as part of the Analyzer details. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Add an ellipsis ("Rerun...") to the button label to indicate that
the user will be prompted to specify parameters before the scan is
actually rerun. This improves UX by aligning with common UI
conventions where an ellipsis suggests additional input or a dialog
before an action executes.
Signed-off-by: Wolfgang Klenk <wolfgang.klenk2@bosch.com>
wkl3nk
requested review from
bs-ondem,
MarcelBochtler,
mnonnenmacher,
nnobelis and
oheger-bosch
as code owners
|
Obviously doing something wrong when creating pull requests directly out of IntelliJ. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance "Rerun" button with ellipsis for clarity
Added an ellipsis ("Rerun...") to the button label to indicate that the user will be prompted to specify parameters before the scan is actually rerun. This improves UX by aligning with common UI conventions where an ellipsis suggests additional input or a dialog
before an action executes.