Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated Localization #39

Merged
merged 2 commits into from
May 20, 2022
Merged

Updated Localization #39

merged 2 commits into from
May 20, 2022

Conversation

paulovnas
Copy link
Contributor

Added Portuguese support
Updated English support (there was a bug in some parameter names)

I'm @pauloinfoluck, I'm now using my personal account, I created the multi-language support issue.
Now I came to contribute with the translation.

NOTE: I updated the en.json file because there were 3 wrong names there, but now everything is ok.

Added Portuguese support

Updated English support (there was a bug in some parameter names)
@bostrot
Copy link
Owner

bostrot commented May 20, 2022

Thanks for the PR. Are you sure you committed the files with the wrong name? In your current PR I can only see that you removed newlines.

@paulovnas
Copy link
Contributor Author

Wow, I'm sorry, what happened was that localization_ui accused that there were unfilled lines in all languages.

But actually it was just the de.json file that had the wrong lines, I checked the project to see which ones were actually correct, so I made another commit now with the right change.

The keys were:

createinstance-text to createdinstance-text
createinstancenuser-text to createdinstancenouser-text
renameinstance-text to renamedinstance-text

Now it's all right

@bostrot
Copy link
Owner

bostrot commented May 20, 2022

Oh I see, thanks for resolving this issue! I was just happy that the english translation worked so I didn't really care to go over the german one.

@bostrot bostrot merged commit 29f62d9 into bostrot:main May 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants