chore: bump i18next peer dependency #38
Conversation
This does not have any impact for dependents except for a warning on install.
| @@ -54,13 +54,13 @@ | |||
| "i18next-multiload-backend-adapter": "^1.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "i18next": "^20.0.0", | |||
| "i18next": "^21.0.0", | |||
There was a problem hiding this comment.
this also requires giving the translations package a major bump, so we don't slip in a breaking change for users down stream
There was a problem hiding this comment.
Good reflex! But as mentioned in the commit and PR:
This does not have any impact for dependents except for a warning on install.
Peer dependencies have 0 impact on the outcome (filewise) of npm/yarn. Only the output will show a yellow warning. Looking at existing projects, most are already using 21 so this would actually resolve this.
There was a problem hiding this comment.
| "i18next": "^21.0.0", | |
| "i18next": "20 - 21", |
is the best solution here I think. we've also used this in the eslint config: https://github.com/bothrs/eslint-config/blob/main/package.json#L83
notice also that peer dependencies never have a ^ or full version number like 21.0.0
This does not have any impact for dependents except for a warning on install.
What
How
Ticket
Ticket
Analytics
Demo