fix: random crashes in credentials.py #2946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.sep and os.sep are supposed to do the same but os.path.sep can lead to random crashes in newer python versions with the following error
AttributeError: module 'posixpath' has no attribute 'sep'
This is also known to other projects and is caused by some broken python versions
pytest-dev/pytest#10547
Toblerity/Fiona#1143
pallets/jinja#1697
The small proposed fix will avoid the issue altogether, even with broken python versions