Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backend/enhancement/implement game page related endpoint #393 #457

Conversation

ahmetkudu
Copy link
Contributor

@ahmetkudu ahmetkudu commented Nov 26, 2023

Pull Request Description

Changes Made

Enhanced both Character and Game entities:

Character Entity:

  1. Added @Column annotations for explicit column names on name and description fields.
  2. Ensured bidirectional mapping with the Game entity using @JoinColumn on the relatedGame field.
  3. Updated characterId initialization to allow for auto-incremented IDs.

Game Entity:

  1. Added @Column annotations for explicit column names on various fields.
  2. Ensured bidirectional mapping with the Character entity using @JoinColumn on the characters field.
  3. Updated gameId initialization to allow for auto-incremented IDs.

Context

Improves code readability, maintains database schema consistency, and ensures clear representation of relationships in both Character and Game entities.

Testing

Extensively tested locally to ensure no regressions and to validate improvements.

Checklist

  • Code adheres to coding standards.
  • Local testing passed without introducing regressions.
  • Documentation updated to reflect changes.

Additional Comments

Seeking review on the modifications made to both Character and Game entities for consistency and adherence to coding standards.

Reviewer Notes

Please review the changes in both the Character and Game entities and provide feedback.

@ahmetkudu ahmetkudu added priority: high High priority task area: milestone About milestone status: review-needed After the issue is completed by the assignee, this label should be chosen to be reviewed by another team: backend Backend team labels Nov 26, 2023
@ahmetkudu ahmetkudu added this to the Milestone 2 milestone Nov 26, 2023
@ahmetkudu ahmetkudu linked an issue Nov 26, 2023 that may be closed by this pull request
@ohbahadiroglu ohbahadiroglu changed the base branch from main to develop November 26, 2023 23:14
Copy link
Contributor

@ohbahadiroglu ohbahadiroglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are in a bit rush for the milestone i will provide detailed feedback later. But for now your work is more than enough. It's great and it works fine, thanks in advance.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: milestone About milestone priority: high High priority task status: review-needed After the issue is completed by the assignee, this label should be chosen to be reviewed by another team: backend Backend team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Gamepage related backend layers
2 participants