Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement Navbar Search #534

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Implement Navbar Search #534

merged 3 commits into from
Dec 16, 2024

Conversation

hikasap
Copy link
Contributor

@hikasap hikasap commented Dec 16, 2024

This pr will create a search input field on navbar. It will allow users to search for stocks and usernames available in application.

Key Changes

  • Add an expandable search input field on navbar
  • Adjust navbar styling
  • Allow username search
  • Allow stock name search

@hikasap hikasap added the frontend issue related with frontend label Dec 16, 2024
@hikasap hikasap added this to the 451 - Milestone 3 milestone Dec 16, 2024
@hikasap hikasap self-assigned this Dec 16, 2024
mahmutbugramert
mahmutbugramert approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mahmutbugramert mahmutbugramert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@mahmutbugramert mahmutbugramert merged commit 2c795ee into dev Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mahmutbugramert mahmutbugramert mahmutbugramert approved these changes

@cemgungor1 cemgungor1 Awaiting requested review from cemgungor1

Assignees

@hikasap hikasap

Labels
frontend issue related with frontend
Projects
None yet
Milestone
451 - Milestone 3
Development

Successfully merging this pull request may close these issues.
2 participants
@hikasap @mahmutbugramert