Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow the "embed" SAPI #332

Closed
feamsr00 opened this issue Nov 22, 2018 · 6 comments
Closed

Allow the "embed" SAPI #332

feamsr00 opened this issue Nov 22, 2018 · 6 comments
Labels

Comments

@feamsr00
Copy link

Feature Request

Have the requirement checker allow the "embed" SAPI.

"embed"!==PHP_SAPI

Thanks!

@theofidry
Copy link
Member

Oh interesting, I did not know about it. Could you just tell me how you manage to get it? I can't find any information on it

@theofidry theofidry added the bug label Nov 23, 2018
@theofidry
Copy link
Member

Hm actually I think I added this guard because of humbug/file_get_contents#23, but this guard doesn't seem to be enough and I'm actually not sure if very useful here. After checking a couple of other projects, I only see Composer with a similar guard.

Any recommendations @kelunik?

@kelunik
Copy link

kelunik commented Nov 23, 2018

Composer should also allow phpdbg, we also allowed embed in Aerys some time ago, but I'm not even sure what embed is.

@theofidry
Copy link
Member

I suppose it won't hurt to add embed then, but I'm still curious as to what it corresponds @feamsr00?

@feamsr00
Copy link
Author

Indeed. Generally speaking if you compile the PHP\ZE into another program (so you could, say, use PHP as a script host) PHP will report as running in a embed SAPI. This makes it more useful in admittedly rather esoteric scenarios, but if the cost of support is 'embed'==PHP_SAPI, why not do it. Make sense?

@theofidry
Copy link
Member

I see. No harm adding it then :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants