Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added badge SVG customization URL query params and associated tests #544

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

erjdev
Copy link
Contributor

@erjdev erjdev commented Oct 23, 2024

Per issue #402 , it seemed like a quick win to add some url params for different badge settings

@boyter boyter merged commit a5418d8 into boyter:master Oct 23, 2024
1 check passed
@boyter
Copy link
Owner

boyter commented Oct 23, 2024

Neat. Cheers. Ill yeet it into production now.

@boyter
Copy link
Owner

boyter commented Oct 24, 2024

Right deployed. Should be all good. Please give it a test and let me know how it goes for you! Ideally with some examples here too. Ill have to update the README.md to ensure people know how to do it as well.

@boyter
Copy link
Owner

boyter commented Oct 24, 2024

Updated README.md with details for this as well.

Thanks so much for taking the time out to do this.

@erjdev
Copy link
Contributor Author

erjdev commented Oct 24, 2024

No worries at all - appreciate the code analysis. scc fulfilled a need I had, and it seems that it's both well maintained and documented. For private repositories it feels a bit more complex, but being able to run it at least locally via CLI? Great.

Glad to contribute, and I hope I can find the time to do so in the future.

@boyter
Copy link
Owner

boyter commented Oct 24, 2024

Yes it won't work with private repositories, but then again the source code is there if someone wants to get it working or set it up for their own use.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

2 participants