Add rft to files #281
Merged
Add rft to files #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 92.90% 92.88% -0.03%
==========================================
Files 161 161
Lines 10578 10605 +27
==========================================
+ Hits 9828 9850 +22
- Misses 750 755 +5 ☔ View full report in Codecov by Sentry. |
kwr3
reviewed
Feb 22, 2024
| """Class for handling output requests in Nexus.""" | ||
| date: str | ||
| output: str | ||
| output_type: OutputType | ||
| output_frequency: FrequencyEnum | ||
| output_frequency_number: None | float | ||
|
|
||
| def to_table_line(self, headers: list[str]) -> str: | ||
| """String representation of the single line within an Output request table.""" | ||
| _ = headers |
There was a problem hiding this comment.
slightly confused on this statement.
There was a problem hiding this comment.
the _ = headers is to dispose of the headers variable which is required to match the variables from the parent class but not required for this object.
kwr3
reviewed
Feb 22, 2024
| @staticmethod | ||
| def get_keyword_mapping() -> dict[str, tuple[str, type]]: | ||
| return {} | ||
|
|
||
|
|
||
| @dataclass(kw_only=True) | ||
| class NexusOutputContents: |
kwr3
reviewed
Feb 22, 2024
| @@ -223,3 +248,14 @@ def _get_output_contents(table_file_as_list: list[str], date: str, output_type: | |||
| resulting_output_contents.append(output_contents_obj) | |||
|
|
|||
| return resulting_output_contents | |||
|
|
|||
| def _add_array_output_request(self, output_request: NexusOutputRequest) -> None: | |||
kwr3
reviewed
Feb 22, 2024
| if headers: | ||
| write_out_headers = ' '.join(headers) | ||
| new_table_as_list.append(write_out_headers) | ||
| new_table_as_list.append(new_obj.to_table_line(headers=headers)) | ||
| new_table_as_list.append(self.table_footer) | ||
| new_table_as_list = [x + '\n' if not x.endswith('\n') else x for x in new_table_as_list] |
cflynn3
approved these changes
Feb 27, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuses code from the add_operators to be able to add any request for data outputs. To make a fully functioning "add_rft" method we would need to be able to add to "WELLLIST" in the network file. #282