Fixing an issue where an incorrect well type will sometimes be assigned when loading in wells. #450
+97
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed when loading in wells.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 191 191
Lines 14075 14076 +1
=======================================
+ Hits 13126 13127 +1
Misses 949 949 ☔ View full report in Codecov by Sentry. |
jonnyh404
reviewed
Mar 4, 2025
| @@ -128,6 +128,8 @@ def _load(self) -> None: | |||
| self._wells = wells | |||
| self.__date_format = date_format | |||
| self._wells_loaded = True | |||
| # Ensure the newly added wells have additional information populated from the surface file. | |||
| self.model.network.get_load_status() | |||
There was a problem hiding this comment.
Does this always mean that network will be loaded after the wells are loaded?
jonnyh404
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Good test for this. If we don't have the call to the network does this test fail?
There was a problem hiding this comment.
It fails for all except the default producer test case, yes.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.