Skip to content

Commit

Permalink
Don't waste performance when there is no page break before function
Browse files Browse the repository at this point in the history
Might improve #280.
  • Loading branch information
Johannes Thoenes committed May 5, 2015
1 parent dd7648f commit b31c381
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions src/layoutBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ LayoutBuilder.prototype.registerTableLayouts = function (tableLayouts) {
LayoutBuilder.prototype.layoutDocument = function (docStructure, fontProvider, styleDictionary, defaultStyle, background, header, footer, images, watermark, pageBreakBeforeFct) {

function addPageBreaksIfNecessary(linearNodeList, pages) {

if(!isFunction(pageBreakBeforeFct)){
return false;
}

linearNodeList = _.reject(linearNodeList, function(node){
return _.isEmpty(node.positions);
});
Expand Down Expand Up @@ -100,12 +105,6 @@ LayoutBuilder.prototype.layoutDocument = function (docStructure, fontProvider, s
});
}

if(!isFunction(pageBreakBeforeFct)){
pageBreakBeforeFct = function(){
return false;
};
}

this.docMeasure = new DocMeasure(fontProvider, styleDictionary, defaultStyle, this.imageMeasure, this.tableLayouts, images);


Expand Down

0 comments on commit b31c381

Please # to comment.