Fix empty PDF issue #2833
Closed
Fix empty PDF issue #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bpampuch#2829 Fix the issue of empty PDF when downloading. * Modify `src/browser-extensions/OutputDocumentBrowser.js` to add a check ensuring the content is correctly embedded before saving the file. * Modify `src/base.js` to add a verification step in the `createPdf` method to ensure the content is correctly embedded. * Update `examples/basics.js` to add a verification step to check the content of the generated PDF. * Update `examples/columns_simple.js` to add a verification step to check the content of the generated PDF. * Add a test case in `tests/unit/Node-interface.spec.js` to verify the content of the generated PDF. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/bpampuch/pdfmake/issues/2829?shareId=XXXX-XXXX-XXXX-XXXX).
|
@Joasper Tests are failing. |
|
No reaction. |
|
Hi @liborm85 I posted the bug, can I help by adding a test case so this fix can be released? |
|
@peirens-bart Add runnable example for reproduce to issue #2829, because It works correctly for me, as mentioned in #2829 (comment). |
|
@liborm85 sorry for the delay, you are correct, the problem is where the doc definition is stored, this has nothing to do with pdfmake |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2829
Fix the issue of empty PDF when downloading.
src/browser-extensions/OutputDocumentBrowser.jsto add a check ensuring the content is correctly embedded before saving the file.src/base.jsto add a verification step in thecreatePdfmethod to ensure the content is correctly embedded.examples/basics.jsto add a verification step to check the content of the generated PDF.examples/columns_simple.jsto add a verification step to check the content of the generated PDF.tests/unit/Node-interface.spec.jsto verify the content of the generated PDF.For more details, open the Copilot Workspace session.