Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vertically Auto-Place Elements #2110

Closed
sombrek opened this issue Mar 1, 2024 · 3 comments · Fixed by #2117
Closed

Vertically Auto-Place Elements #2110

sombrek opened this issue Mar 1, 2024 · 3 comments · Fixed by #2117
Labels
enhancement New feature or request pr welcome We rely on a community contribution to improve this.

Comments

@sombrek
Copy link
Contributor

sombrek commented Mar 1, 2024

Is your feature request related to a problem? Please describe.

Problem: Elements in vertical pools and lanes are auto-placed horizontally.

Describe the solution you'd like

Auto-place elements within vertical containers vertically from top to bottom. Make Sequence and Message Flows match this direction.

In a more abstract way: The result model should look like a horizontally modeled process that was mirrored on the model axis from top-left to bottom-right.

sample-auto-place

Describe alternatives you've considered

Not implementing this feature. But I think it's worth now that layouting vertical containers is possible.

At the moment I don't see a way to make this work in general, i.e. for models without vertical pools. So I would limit this feature to the insides of vertical pools.

Additional context

Related to #507

I would like to make a contribution.

@sombrek sombrek added the enhancement New feature or request label Mar 1, 2024
@sombrek
Copy link
Contributor Author

sombrek commented Mar 4, 2024

I might deviate from the system explained above when it comes to data objects/stores and text annotations.
Below please find the current horizontal behavior for reference and my suggestion on implementing data object and text annotation placement for vertical layouts.
Another tool I tried places both on the right side. For me, extending the model to the right feels more correct.
Any strong opinions on your side?

data-store-suggestion

@barmac
Copy link
Member

barmac commented Mar 6, 2024

Hi,

I think it makes sense to append to the bottom for the flow elements in a vertical participant, but as you noticed artifacts should still take place to the top-right from an element. The behavior should not be present outside of vertical pools though. Feel free to tag me if you prepare a contribution.

@nikku nikku added pr welcome We rely on a community contribution to improve this. backlog Queued in backlog labels Mar 7, 2024
@nikku
Copy link
Member

nikku commented Mar 7, 2024

Tagging as pr welcome and moving to backlog.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request pr welcome We rely on a community contribution to improve this.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants