Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: import explicit files #869

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

chore: import explicit files #869

wants to merge 2 commits into from

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 12, 2024

This prepares us to migrate diagram-js to an ES module.

Related to #863

@nikku nikku requested review from barmac, a team and marstamm and removed request for a team March 12, 2024 09:59
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 12, 2024
@nikku
Copy link
Member Author

nikku commented Mar 12, 2024

Some tests are failing. I'm investigating why.

@nikku nikku marked this pull request as draft March 12, 2024 10:22
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Mar 12, 2024
@nikku nikku force-pushed the esm branch 2 times, most recently from 4915617 to a92a7bc Compare March 12, 2024 16:28
@nikku nikku marked this pull request as ready for review March 12, 2024 16:30
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 12, 2024
@nikku
Copy link
Member Author

nikku commented Mar 12, 2024

All fixed!

nikku added 2 commits March 12, 2024 22:35
This prepares us to migrate diagram-js to an ES module.

Related to #863
This prepares us to migrate diagram-js to an ES module.

Related to #863
@nikku
Copy link
Member Author

nikku commented Mar 12, 2024

Validated by #870 that this also works with strict (ESM) import checking.

@nikku nikku mentioned this pull request Mar 12, 2024
@nikku nikku marked this pull request as draft March 12, 2024 22:01
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Mar 12, 2024
@nikku nikku added the backlog Queued in backlog label Mar 14, 2024 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Mar 14, 2024
@nikku nikku removed their assignment Oct 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backlog Queued in backlog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant