fix: correct set to properly handle <0> keys in path

+ verify handling of <''> keys, too
bpmn-io · Mar 15, 2021 · 682e3af · 682e3af
1 parent 9b9ba30
commit 682e3af
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/lib/object.js b/lib/object.js
@@ -1,6 +1,10 @@
 import { forEach } from './collection';
 
-import { isObject, isUndefined } from './lang';
+import {
+  isObject,
+  isUndefined,
+  isDefined
+} from './lang';
 
 
 /**
@@ -37,11 +41,11 @@ export function set(target, path, value) {
     var nextKey = path[idx + 1];
     var nextTarget = currentTarget[key];
 
-    if (nextKey && !nextTarget) {
+    if (isDefined(nextKey) && !nextTarget) {
       nextTarget = currentTarget[key] = isNaN(+nextKey) ? {} : [];
     }
 
-    if (!nextKey) {
+    if (isUndefined(nextKey)) {
       if (isUndefined(value)) {
         delete currentTarget[key];
       } else {

diff --git a/test/object.spec.js b/test/object.spec.js
@@ -305,18 +305,40 @@ describe('object', function() {
       expect(set({}, ['a'], true)).to.eql({
         a: true
       });
+
+      expect(set({}, [''], 'A')).to.eql({
+        '': 'A'
+      });
+
+      expect(set({}, [ 0 ], 'A')).to.eql({
+        '0': 'A'
+      });
     });
 
 
     it('should set array value', function() {
 
       expect(set([0, 1, 2], [1], 'A')).to.eql([ 0, 'A', 2]);
 
+      expect(set([0, 1, 2], [1], 0)).to.eql([ 0, 0, 2]);
+
       expect(set({
         a: [0, 0]
       }, [ 'a', 1 ], 1)).to.eql({
         a: [ 0, 1 ]
       });
+
+      expect(
+        set({
+          a: [
+            { b: 'FOO' }
+          ]
+        }, [ 'a', 0, 'b' ], 'BAR')
+      ).to.eql({
+        a: [
+          { b: 'BAR' }
+        ]
+      });
     });
 
 
@@ -336,6 +358,10 @@ describe('object', function() {
       expect(set({
         a: false
       }, [ 'a' ], undefined)).to.eql({});
+
+      expect(set({
+        '': false
+      }, [ '' ], undefined)).to.eql({});
     });