Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

findIndex has wrong type definitions #36

Closed
barmac opened this issue Jan 26, 2024 · 1 comment
Closed

findIndex has wrong type definitions #36

barmac opened this issue Jan 26, 2024 · 1 comment
Assignees
@abdul99ahad
Labels
bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Member

barmac commented Jan 26, 2024

Describe the Bug

In the type definitions, findIndex is supposed to return number. However, it returns string if an object is passed.

https://github.com/bpmn-io/min-dash/blob/main/lib/collection.js#L97

Steps to Reproduce

  1. do this
  2. do that
  3. now this happens

Expected Behavior

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@barmac barmac added the bug Something isn't working label Jan 26, 2024
@barmac
Copy link
Member Author

barmac commented Jan 26, 2024

The name is confusing as well...

@nikku nikku added the backlog Queued in backlog label Jan 29, 2024 — with bpmn-io-tasks
@nikku nikku added good first issue Good for newcomers spring cleaning Could be cleaned up one day pr welcome We rely on a community contribution to improve this. labels Jan 29, 2024
@abdul99ahad abdul99ahad self-assigned this Aug 5, 2024
@abdul99ahad abdul99ahad added the ready Ready to be worked on label Aug 5, 2024 — with bpmn-io-tasks
@abdul99ahad abdul99ahad added in progress Currently worked on and removed backlog Queued in backlog ready Ready to be worked on labels Aug 5, 2024
@abdul99ahad abdul99ahad mentioned this issue Aug 6, 2024
Merged
@abdul99ahad abdul99ahad added the needs review Review pending label Aug 6, 2024 — with bpmn-io-tasks
@abdul99ahad abdul99ahad removed the in progress Currently worked on label Aug 6, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 6, 2024
abdul99ahad added a commit that referenced this issue Aug 6, 2024
@abdul99ahad
fix: fixed type definition for findIndex
8da3733 
Closes #36
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Aug 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@abdul99ahad abdul99ahad

Labels
bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikku @barmac @abdul99ahad