Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix set #18

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fix set #18

merged 2 commits into from
Mar 15, 2021

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 15, 2021

Closes #17

nikku added 2 commits March 15, 2021 11:16
@nikku
fix: correct set to properly handle <0> keys in path
682e3af 
+ verify handling of <''> keys, too
@nikku
fix: scaffold over <null> targets in set
46920c8 
This ensures `null` targets are treated as if the value
does not exist during scaffolding.

```javascript
set({ a: null }, [ 'a', 'b', 'c' ], 'C')
```
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 15, 2021
@nikku nikku requested a review from philippfromme March 15, 2021 10:21
@nikku nikku mentioned this pull request Mar 15, 2021
Closed
philippfromme
philippfromme approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. 🤩

@fake-join fake-join bot merged commit ebca59f into master Mar 15, 2021
@fake-join fake-join bot deleted the fix-set branch March 15, 2021 10:29
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 15, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key of Number 0 Leads to Unexpected Result
2 participants
@nikku @philippfromme