-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: make a PNG export of the figure available in the kernel #1397
feat: make a PNG export of the figure available in the kernel #1397
Conversation
LGTM, would like a 2nd opinion from @SylvainCorlay or @martinRenou on this. Some thoughts that don't need addressing perse:
|
1749522
to
d2382a9
Compare
Rebased |
@meeseeksdev backport to 0.12.x |
…ble in the kernel
Thanks! Nice! Which release will this feature be in? 😸 |
0.12.31 :) It should come soon |
…7-on-0.12.x Backport PR #1397 on branch 0.12.x (feat: make a PNG export of the figure available in the kernel)
if self._upload_png_callback: | ||
raise Exception('get_png_data already in progress') | ||
self._upload_png_callback = callback | ||
self.send({'type': 'upload_png', 'scale': scale}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work, though this thing gets stuck in display-less CI, so I cannot write a test for it. Any trick I need to know to write a Python unit test that calls this function?
A solution for #1393
Usage: