Fixes bugs introduced by #108 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following items introduced by #108:
The automerge workflow cannot trigger in main on check_suite completion from a PR. After a successful Travis run on a PR, Travis now triggers the automerge workflow directly via a status update.
For security reasons, GitHub Actions workflows cannot be triggered by jobs in other workflows via the default GITHUB_TOKEN, so the automerge job cannot catalyze the scoring workflow using this token. GITHUB_TOKEN has now been updated to WORKFLOW_TOKEN, which was created for use in these workflows and owned by the Brain-Score organization.
Also for security reasons, Travis does not make encrypted environment variables available to forks. This PR separates Travis tests for each Python version into "public" and "private" jobs, where "private" jobs will not run on PRs from forks, and marks tests requiring these variables as private.
To reduce test runtime, this PR removes
python 3.7as a supported version. As per add python 3.7 to build matrix again #171, we anticipate re-incorporating3.7after additional measures have been taken to further reduce testing time (e.g. only run travis tests for plugins when first added #173).This PR also adds more flexibility in specifying scoring parameters by converting some previously required params to fully optional.