Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: refactor blocking calls out from events in unit tests #688

Merged
merged 2 commits into from
May 15, 2023

Conversation

Mishura4
Copy link
Member

This fixes start_timer and message_collector tests failing due to the shard thread being blocked

Mishura4 added 2 commits May 14, 2023 15:34
this fixes start_timer, message_collector unit test failing due to blocking calls in the first shard's thread
@netlify
Copy link

netlify bot commented May 14, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 65cb206
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6461542d66c7bf0008f7f318
😎 Deploy Preview https://deploy-preview-688--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Mishura4 Mishura4 changed the title fix: refactor blocking calls out from events in unit tests test: refactor blocking calls out from events in unit tests May 14, 2023
@braindigitalis braindigitalis merged commit a0881a6 into brainboxdotcc:dev May 15, 2023
@Mishura4 Mishura4 deleted the unittest_fix branch August 8, 2023 20:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants