-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Add more definitions to built .a #3
Conversation
@aran Sorry for the delay. We tested your changes on a couple of internal repositories and it seems to work just fine. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM but at brainhive all of the commits have to be signed. Can you do that? For more information: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
OK, fixed up that commit verification issue. I also removed the MODULE.bazel.lock change, not sure if you wanted that included. If so, I figure you can decide that and commit it, since it's not strictly related to this. With respect to the changes in this PR, it's been working for me without issue so far, but just want to be clear it is a bit concerning to me on several aspects:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Check! Let me know if it works for you on the
I can say with confidence that I have a very poor understanding of how all of this works in the first place. It has been a matter of making changes, testing, verifying, etc. I still don't get why the original version worked (it might be due to some magic happening in
Me neither. If I have some time in the upcoming weeks I'll look further into this. I also wanted to add support for more architectures. |
Add more C files as dependencies, along with several more defines, to define more symbols in the built result.
Tested by building and running a rust binary that uses diesel with this as the dependency, on a mac, with
--platforms
Fixes #2.