🐛 cast tool_calls arguments correctly inside message_deltas #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparcus
commented
Sep 5, 2024
|
Great catch! Thanks for the improvement and additional tests! ❤️💛💙💜 |
brainlid
added a commit
that referenced
this pull request
Oct 28, 2024
* 'main' of github.com:brainlid/langchain: Add AWS Bedrock support to ChatAnthropic (#154) Handle functions with no parameters for Google AI (#183) Handle missing token usage fields for Google AI (#184) Handle empty text parts from GoogleAI responses (#181) Support system instructions for Google AI (#182) feat: add OpenAI's new structured output API (#180) Support strict mode for tools (#173) Do not duplicate tool call parameters if they are identical (#174) 🐛 cast tool_calls arguments correctly inside message_deltas (#175)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, tool call arguments in deltas which contained several empty spaces were missing data when being cast.
While triaging this issue I also added some extra tests checking for correct casting of spaces.