Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add licence type to Nuget Package #92

Closed
thompson-tomo opened this issue Jan 23, 2024 · 1 comment · Fixed by #93
Closed

Add licence type to Nuget Package #92

thompson-tomo opened this issue Jan 23, 2024 · 1 comment · Fixed by #93

Comments

@thompson-tomo
Copy link

thompson-tomo commented Jan 23, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

In dependency track this package is reporting as not having a licence type specified

Describe the solution you'd like

The PackageLicenseExpression property is set in the csproj so that the NUGET package has the information. This can then be included in the SBOM so that analysis can occur in the appropriate tools

Describe alternatives you've considered

Ignore them, bundle licence file into package & reference the file.

Additional context

N:a
brantburnett added a commit that referenced this issue Jan 23, 2024
@brantburnett
Switch NuGet to use a license expression to assist with SBOM analysis
b773ba8 
The COPYING.txt file, which was ported from the original C++
implementation, appears to be the basic BSD-3-Clause license except
for the parts about the testdata. However, the testdata is not included
in the NuGet package so isn't relevant.

Update the NuGet copyright to match the copyright notice in COPYING.txt.

Also embed the README.md file in the package.

Fixes #92
@brantburnett brantburnett mentioned this issue Jan 23, 2024
Merged
brantburnett added a commit that referenced this issue Jan 23, 2024
@brantburnett
Switch NuGet to use a license expression to assist with SBOM analysis (…
adcc68b 
…#93)

The COPYING.txt file, which was ported from the original C++
implementation, appears to be the basic BSD-3-Clause license except for
the parts about the testdata. However, the testdata is not included in
the NuGet package so isn't relevant.

Update the NuGet copyright to match the copyright notice in COPYING.txt.

Also embed the README.md file in the package.

Fixes #92
@brantburnett
Copy link
Owner

Thanks for pointing this out. I've switched to using an SPDX instead of embedding the text in the NuGet, this is releasing shortly as 1.1.5.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch NuGet to use a license expression to assist with SBOM analysis brantburnett/Snappier
2 participants
@brantburnett @thompson-tomo