Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update install extension text to remove review language #11214

Closed
rebron opened this issue Aug 13, 2020 · 7 comments · Fixed by brave/brave-core#6588
Closed

update install extension text to remove review language #11214

rebron opened this issue Aug 13, 2020 · 7 comments · Fixed by brave/brave-core#6588

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 13, 2020

Description

Current text when installing extensions implies a Brave review.

Text should read as:
"Brave does not review extensions for security and safety. Only install this extension if you trust the developer."

Steps to Reproduce

  1. Go to Extension Web Store https://chrome.google.com/webstore/category/extensions?hl=en-US
  2. Select an extension to 'Add to Brave'
  3. Click 'Add to Brave' and notice dialog.

Actual result:

Screen Shot 2020-08-12 at 9 18 01 PM

Expected result:

image

Reproduces how often:

See str.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related prior issues:
#1408
#3231

cc: @karenkliu @fmarier @pes10k

@rebron rebron added needs-text-change This change requires some careful wording. feature/extensions OS/Desktop needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Aug 13, 2020
@bbondy
Copy link
Member

bbondy commented Aug 13, 2020

Maybe:
Brave does not review extensions for security and safety. Only install this extension if you trust the developer.

@rebron rebron added the l10n label Aug 18, 2020
@rebron rebron self-assigned this Aug 18, 2020
@rebron
Copy link
Collaborator Author

rebron commented Aug 18, 2020

Let's go with"Brave does not review extensions for security and safety. Only install this extension if you trust the developer." and I'll update the original issue.

@karenkliu
Copy link

Designs added!

@mkarolin
Copy link
Contributor

mkarolin commented Sep 9, 2020

@rebron, does this need to be uplifted (and if yes how high)?

@rebron rebron removed their assignment Sep 22, 2020
@rebron rebron removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Sep 22, 2020
@LaurenWags
Copy link
Member

Clarifications requested from @rebron

@LaurenWags
Copy link
Member

Confirmed with @rebron this issue is for the text change, no design changes as of right now.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 5, 2020

Verified passed with

Brave | 1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (x86_64)
-- | --
Revision | ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description.

Confirmed displays as per the issue description:
Screen Shot 2020-10-05 at 12 49 53 PM

Note, extension name is not listed on the dialog box, this is logged with #5575


Verification passed on

Brave 1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (64-bit)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS Ubuntu 18.04 LTS

Verified STR from description.

Confirmed displays as per the issue description:

image

The message is not translated.


Verification passed on

Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Verified STR from description.

Confirmed displays as per the issue description:
image

@rebron rebron changed the title [Desktop] update install extension text to remove review language update install extension text to remove review language Oct 26, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment