Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changelog file should have our own information #12

Closed
bbondy opened this issue Dec 5, 2017 · 5 comments
Closed

Changelog file should have our own information #12

bbondy opened this issue Dec 5, 2017 · 5 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@bbondy
Copy link
Member

bbondy commented Dec 5, 2017

Changelog file should have our own information
See: #12 (comment)

@bbondy bbondy added this to the Milestone 1: Open Source milestone Dec 5, 2017
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Milestone 2: To offer Installable and updatable builds Mar 19, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
patchfile modifications: split master_patch.patch using new utility
@bbondy bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Milestone 3: June-July Jun 6, 2018
@simonhong
Copy link
Member

I found some google urls for release note in ./src/chrome/installer/linux/debian/build.sh.

verify_channel() {
  case $CHANNEL in
    stable )
      CHANNEL=stable
      RELEASENOTES="http://googlechromereleases.blogspot.com/search/label/Stable%20updates"
      ;;
    unstable|dev|alpha )
      CHANNEL=unstable
      RELEASENOTES="http://googlechromereleases.blogspot.com/search/label/Dev%20updates"
      ;;
    testing|beta )
      CHANNEL=beta
      RELEASENOTES="http://googlechromereleases.blogspot.com/search/label/Beta%20updates"
      ;;
    * )
      echo
      echo "ERROR: '$CHANNEL' is not a valid channel type."
      echo
      exit 1
      ;;
  esac
}

@bbondy
Copy link
Member Author

bbondy commented Aug 16, 2018

@simonhong, how are these URLs exposed to users? Do we need this for 0.55.x or can we put it to Backlog?

@simonhong
Copy link
Member

/usr/share/doc/brave-browser-dev/changelog.gz is installed and extracted text file contents includes it.

brave-browser-dev (0.54.0) dev; urgency=low

  * Build spec: https://chromium.googlesource.com/chromium/src.git/+/0.54.0/
  * Release Notes:
    http://googlechromereleases.blogspot.com/search/label/Dev%20updates

 -- Brave Software <support+laptop@brave.com>  Tue, 03 Feb 2009 14:54:35 -0800

@bbondy
Copy link
Member Author

bbondy commented Aug 18, 2018

I'll move to backlog.

@bbondy bbondy changed the title Brave brand support URLs and icons Changelog file should have our own information Aug 18, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, Backlog Aug 18, 2018
@srirambv srirambv mentioned this issue Sep 28, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 5, 2018
@Mikaela
Copy link

Mikaela commented Oct 14, 2018

I think #1084 is closely related.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

6 participants