Fix crash when fetching Rewards Widget estimated earnings

[tmancey]

Description

Fix crash when fetching Rewards Widget estimated earnings. Only reproduced on Windows, however the issue can occur on macOS, Linux and Android.

Steps to Reproduce

1. Fresh installation
2. Open/close new tabs

Actual result:

Ads service is restarted (see console logs)

Expected result:

Ads service should not be restarted

Reproduces how often:

Intermittent issue. Reproduced on Windows

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[kjozwiak]

Fix crash when fetching Rewards Widget estimated earnings. Only reproduced on Windows, however the issue can occur on macOS, Linux and Android.

Is there anything specific that needs to be checked on Android? Believe Android doesn't have the Rewards widget. Do we basically just need to check that ads/reward estimates via the settings page is working?

[tmancey]

@kjozwiak After further thoughts, yes can we just run a basic verification test to make sure an ad appears.

[GeetaSarvadnya]

Verification passed on

Brave | 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | Windows 10 OS Version 2004 (Build 19041.804)

• Verified the test plan from Fixed crash when fetching Rewards Widget estimated earnings brave-core#8114

Confirm Rewards Widget estimated earnings are updated after a fresh install

Clean install - Estimated earnings in rewards widget is 0.000 BAT

After viewing the 1st Ad, the rewards widget is updated correctly

Confirm Rewards Widget estimated earnings are updated after refreshing a new tab page

After viewing the 2nd Ad, refresh NTP updates the Rewards Widget estimated earnings

• Ensured that refreshing brave://newtab right after viewing an ad doesn't crash Brave and updates estimated earnings correctly
• Ensured that Restarting ads service isn't appearing in the CLI/terminal logs

---

Verified passed with

Brave | 1.21.76 Chromium: 89.0.4389.86 (Official Build) (x86_64)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | macOS Version 10.15.7 (Build 19H524)

Verified the test plan from brave/brave-core#8114

• ensured that clicking on Start using Rewards via brave://newtab works as expected
• ensured that estimated earnings is being updated in a previously opened brave://newtab after viewing an ad
• ensured that the correct estimated earnings is being displayed when opening a new brave://newtab after viewing an ad
• ensured that refreshing brave://newtab right after viewing an ad doesn't crash Brave and updates estimated earnings correctly
• ensured that that estimated earnings under brave://rewards match the value that's being displayed under brave://newtab
• ensured that Restarting ads service isn't appearing in the CLI/terminal logs

---

Verification passed on

Brave	1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
Revision	0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS	Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#8114

• ensured that clicking on Start using Rewards via brave://newtab works as expected
• ensured that estimated earnings is being updated in a previously opened brave://newtab after viewing an ad
• ensured that the correct estimated earnings is being displayed when opening a new brave://newtab after viewing an ad
• ensured that refreshing brave://newtab right after viewing an ad doesn't crash Brave and updates estimated earnings correctly
• ensured that that estimated earnings under brave://rewards match the value that's being displayed under brave://newtab
• ensured that Restarting ads service isn't appearing in the CLI/terminal logs

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.21.76 x64 build

• Verified no crash when viewing an ad and reloading NTP
• No checked done for rewards widget as its not available for Android

---

Verification passed on Samsung Tab A with Android 10 running 1.21.76 x64 build

• Verified no crash when viewing an ad and reloading NTP
• No checked done for rewards widget as its not available for Android