Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed crash when fetching Rewards Widget estimated earnings - 1.21.x #8144

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 5, 2021

Uplift of #8114
Resolves brave/brave-browser#14447

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.21.x - Release milestone Mar 5, 2021
@tmancey tmancey requested a review from a team March 5, 2021 14:49
@tmancey tmancey self-assigned this Mar 5, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Mar 9, 2021

Restarting pre-init due to the following failure:

[2021-03-05T14:56:24.976Z] Searching s3://**** for object:'brave-browser-build-pr/issues/14447-1.21.x/1/windows/build-status.txt'
[2021-03-05T14:56:25.002Z] Search complete
groovy.lang.MissingPropertyException: No such property: FAILED_STAGE for class: Script1

Restarting macOS as build failed as per https://ci.brave.com/job/pr-brave-browser-issues-14447-1.21.x-macos/1/execution/node/165/log/.

13:55:35  FAILED: obj/components/safe_browsing/content/common/interfaces/safe_browsing.mojom.o 

Restarting post-init due to the following failure:

[2021-03-05T14:55:34.990Z] Searching s3://**** for object:'brave-browser-build-pr/issues/14447-1.21.x/1/windows/build-status.txt'
[2021-03-05T14:55:35.096Z] Search complete
groovy.lang.MissingPropertyException: No such property: FAILED_STAGE for class: Script1

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.21.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8114 (comment).

@kjozwiak kjozwiak merged commit dfc7c93 into 1.21.x Mar 9, 2021
@kjozwiak kjozwiak deleted the issues/14447-1.21.x branch March 9, 2021 08:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants