Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enabling Rewards from panel should have waiter message when opting in #1502

Closed
LaurenWags opened this issue Oct 10, 2018 · 5 comments · Fixed by brave/brave-core#721
Closed

Comments

@LaurenWags
Copy link
Member

Description

Similar to issue reported in #1099. If you are using a fresh profile and you click on the BAT logo and are prompted to join Brave Rewards, when you click 'Join Rewards' there is a lag. It would be helpful if this had a similar waiter message as when opting in from chrome://rewards. I'm not sure if the exact same one is appropriate, users might not know what 'creating wallet' means here.

Steps to Reproduce

  1. Clean profile.
  2. Click on BAT logo in URL bar.
  3. On Brave Rewards panel click on JOIN REWARDS

Actual result:

Note lag, doesn't seem like anything is happening.
panel

Expected result:

Waiter message similar to when opting in from chrome://rewards page

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes
  • Does it reproduce on browser-laptop? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @NejcZdovc @jenn-rhim

@LaurenWags LaurenWags added design A design change, especially one which needs input from the design team feature/rewards browser-laptop-parity QA/Yes labels Oct 10, 2018
@LaurenWags LaurenWags added this to the 1.0 (0.56.x) milestone Oct 10, 2018
@srirambv
Copy link
Contributor

Reproduced on Linux as well

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 26, 2018

The referenced issue #1838 is still reproducible on Dev Build version 0.57.3. This issue is not there on Release build 0.55.20.

1838

@NejcZdovc
Copy link
Contributor

#1838 was not included in 0.57.3

@kjozwiak
Copy link
Member

Waiting for #1838 to be fixed as it's reproducible under 0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit) as well. Once #1838 has been resolved, this can be verified as well.

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 31, 2018

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

screen shot 2018-10-31 at 4 47 54 pm

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

1502

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

image

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants