Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Explanatory text in Private Window does not show the correct Mac keyboard shortcuts for Tor windows. #1688

Closed
petemill opened this issue Oct 18, 2018 · 1 comment · Fixed by brave/brave-core#684
Closed

Explanatory text in Private Window does not show the correct Mac keyboard shortcuts for Tor windows. #1688

petemill opened this issue Oct 18, 2018 · 1 comment · Fixed by brave/brave-core#684
Assignees
@petemill
Labels
feature/private-browsing feature/tor feature/user-interface All UI related needs-text-change This change requires some careful wording. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.56.x - Release ...

Comments

@petemill
Copy link
Member

From @davidtemkin in #1671:

Explanatory text in Private Window does not show the correct Mac keyboard shortcuts for Tor windows.

-- Incorrect: "Open a Private Window with Tor from the menu, or with Alt+Shift+N or Option+Shift+N."
-- Correct: "Open a Private Window with Tor from the menu, or with Alt+Shift+N (Windows) or ⌥⌘N (Mac)" (That is standard notation for option-command-N)

Better yet, only show the correct platform shortcut on each platform.
@petemill petemill added needs-text-change This change requires some careful wording. feature/user-interface All UI related labels Oct 18, 2018
@petemill petemill added this to the 0.56.x - Beta milestone Oct 18, 2018
@petemill petemill self-assigned this Oct 18, 2018
petemill added a commit to brave/brave-core that referenced this issue Oct 18, 2018
@petemill
Private New Tab Page now shows only applicable Mac / non-Mac keys to …
f848c5d 
…open Tor

Also corrects the actual keys in the string

Fix brave/brave-browser#1688
@petemill petemill mentioned this issue Oct 18, 2018
Merged
18 tasks
@tildelowengrimm tildelowengrimm mentioned this issue Oct 19, 2018
Closed
petemill added a commit to brave/brave-core that referenced this issue Oct 20, 2018
@petemill
Private New Tab Page now shows only applicable Mac / non-Mac keys to …
42a3ef8 
…open Tor

Also corrects the actual keys in the string

Fix brave/brave-browser#1688
@davidtemkin davidtemkin mentioned this issue Oct 23, 2018
Closed
4 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Oct 31, 2018 •
edited by srirambv
Loading

Verified passed with macOS x64 10.12.6

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • Verified only text for macOS shortcut was displayed
    screen shot 2018-10-31 at 4 40 55 pm

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows
  • Verified shortcut key Alt+Shift+N to open a "Private Window with Tor" is displayed correctly
    image

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux
  • Verified correct shortcut key for Tor Window is shown
    image

@kjozwiak kjozwiak mentioned this issue Nov 9, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@petemill petemill

Labels
feature/private-browsing feature/tor feature/user-interface All UI related needs-text-change This change requires some careful wording. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Private New Tab Page now shows only applicable Mac / non-Mac keys to open Tor brave/brave-core
6 participants
@tildelowengrimm @petemill @kjozwiak @srirambv @LaurenWags @GeetaSarvadnya