Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

remove sync this device interface #2156

Closed
cezaraugusto opened this issue Nov 15, 2018 · 3 comments · Fixed by brave/brave-core#913
Closed

remove sync this device interface #2156

cezaraugusto opened this issue Nov 15, 2018 · 3 comments · Fixed by brave/brave-core#913
Assignees
@cezaraugusto
Labels
about-pages/sync feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.57.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

this is not needed per design spec

screen shot 2018-11-14 at 9 00 50 pm
@cezaraugusto cezaraugusto added this to the 0.57.x - Beta milestone Nov 15, 2018
@cezaraugusto cezaraugusto self-assigned this Nov 15, 2018
cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 15, 2018
@cezaraugusto
remove sync this device option
545c7a1 
closes brave/brave-browser#2156
@cezaraugusto cezaraugusto mentioned this issue Nov 15, 2018
Merged
@LaurenWags
Copy link
Member

Verified passed with

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X

screen shot 2018-11-29 at 11 21 39 am

@srirambv
Copy link
Contributor

Removed QA pass label. Need to verify it against beta again

This was referenced Dec 4, 2018
Closed
Closed
Closed
Closed
@btlechowski
Copy link

btlechowski commented Dec 11, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

image

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

image

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

screen shot 2018-12-12 at 10 11 50 am

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@cezaraugusto cezaraugusto

Labels
about-pages/sync feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

remove sync this device option brave/brave-core
5 participants
@cezaraugusto @rebron @srirambv @LaurenWags @btlechowski